Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update old dependencies and refresh Go version #185

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update old dependencies and refresh Go version #185

merged 1 commit into from
Jan 24, 2024

Conversation

kwilczynski
Copy link
Member

@kwilczynski kwilczynski commented Jan 24, 2024 •
edited
Loading

Update older build-time dependencies, and while at it, refresh the Go version to release 1.20.

Additionally, update GitHub actions releases, too.

Related:

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 24, 2024
@openshift-ci openshift-ci bot requested review from mrunalp and sameo January 24, 2024 14:32
@kwilczynski kwilczynski force-pushed the feature/update-old-dependencies branch 3 times, most recently from 56187fd to 6a80eb2 Compare January 24, 2024 15:06
@kwilczynski
Copy link
Member Author

/assign kwilczynski

@kwilczynski kwilczynski force-pushed the feature/update-old-dependencies branch 3 times, most recently from f56582a to 7c6e113 Compare January 24, 2024 15:25
@kwilczynski kwilczynski force-pushed the feature/update-old-dependencies branch from 7c6e113 to bef41c6 Compare January 24, 2024 15:33
kwilczynski
kwilczynski commented Jan 24, 2024
View reviewed changes
go.mod
@@ -1,13 +1,13 @@
module github.com/cri-o/ocicni

go 1.17
go 1.20
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the reviewer:

This is needed to be able to update some of our packages that have moved onto the new Go internal API of the Context package:

@kwilczynski
Copy link
Member Author

/release-note-none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 24, 2024
@kwilczynski
Copy link
Member Author

/kind dependencies

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@kwilczynski: The label(s) kind/dependencies cannot be applied, because the repository doesn't have them.

In response to this:

/kind dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7bfed63 into cri-o:master Jan 24, 2024
4 checks passed
@kwilczynski kwilczynski deleted the feature/update-old-dependencies branch January 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@sameo sameo Awaiting requested review from sameo

Assignees

@kwilczynski kwilczynski

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwilczynski @haircommander